Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support to disable registry filtering in Containerd #373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phillebaba
Copy link
Member

@phillebaba phillebaba commented Feb 29, 2024

Some users may want to mirror all images without specifying a registry. This change modifies the filtering regex to allow for an empty filter registries list. Images will still be filtered however to contain a registry in the reference.

This change would resolve a k3s specific use case for now, but should be supported as an option in Spegel also.
k3s-io/k3s#9590

@vflaux
Copy link

vflaux commented Jun 19, 2024

With no registry configured, no mirror is configured in containerd config.
Shouldn't you add a default configuration to mirror all registries to spegel in this case ? There is a special hostname "_default" for this: https://github.com/containerd/containerd/blob/main/docs/hosts.md#registry-host-namespace.

@sfackler
Copy link

sfackler commented Aug 5, 2024

@phillebaba Is there anything blocking this from merging?

@phillebaba
Copy link
Member Author

@sfackler not really, I will rebase and just check my work one more time before merging. Just forgot about this while doing other stuff.

@sfackler
Copy link

sfackler commented Aug 5, 2024

Thanks!

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
pkg/oci/containerd.go 59.86% <100.00%> (+0.27%) ⬆️

@vflaux
Copy link

vflaux commented Sep 12, 2024

Hi,
The current chart do not add the --registry if spegel.registries is empty in values but spegel expect this argument.
Either the chart should add it even if empty or this argument should be optional with empty array by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants