Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CRI-O #428

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add support for CRI-O #428

wants to merge 1 commit into from

Conversation

phillebaba
Copy link
Member

@phillebaba phillebaba commented Apr 9, 2024 •
edited
Loading

Part of #36

Depends on cri-o/cri-o#7748

@phillebaba phillebaba marked this pull request as draft April 9, 2024 15:39
@sohankunkerkar
Copy link

Hey @phillebaba, cri-o/cri-o#7748 has merged now. Let me know if you need any help with pushing this PR to the finish line.

@alexp-openai
Copy link

Any updates or an ETA for CRI-O support? Would be good to have it!

@phillebaba
Copy link
Member Author

I should probably document this but I have paused this work for now. The reason being that Spegel does not work with CRIO. When I started working on this i was using the storage client to get the individual layers. What I did not know was that unlike Containerd, CRIO never stores the compressed layers. Instead when I was getting the layers I was getting the re-compressed locally. This in turn caused a bunch of problems as it would only work with images that have been compressed using the same compression implementation that CRIO was using.

Until this issue can be resolved I cant really see a way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phillebaba @sohankunkerkar @alexp-openai