Use buffer pool for proxy copying data #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
feature/buffer-pool
branch
from
1e3b734
to
f03ee09
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
phillebaba
force-pushed
the
feature/buffer-pool
branch
2 times, most recently
from
da1e168
to
2c0b6d0
Compare
Signed-off-by: Philip Laine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the HTTP proxy use a buffer pool when copying data between a response and request. It does not change the buffer size which still is what it was before. Future work could be done to test if changing the buffer size would improve performance.
Relates to #546