Add from_coins arg to payto/paytomany #5432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyRand
force-pushed
the
rpc-from-coins
branch
from
7e7739a
to
1386706
Compare
JeremyRand
force-pushed
the
rpc-from-coins
branch
2 times, most recently
from
4e2bd86
to
928eba3
Compare
|
@ecdsa Rebased. |
SomberNight
reviewed
Sep 20, 2019
electrum/commands.py
Outdated
| coins = wallet.get_spendable_coins(domain, self.config) | ||
| coins = wallet.get_spendable_coins(domain_addr, self.config) | ||
| if domain_coins is not None: | ||
| coins = list([coin for coin in coins if (coin['prevout_hash'] + ':' + str(coin['prevout_n']) in domain_coins)]) |
There was a problem hiding this comment.
The list() cast looks redundant. Are you trying to make a copy?
Suggested change
| coins = list([coin for coin in coins if (coin['prevout_hash'] + ':' + str(coin['prevout_n']) in domain_coins)]) | |
| coins = [coin for coin in coins if (coin['prevout_hash'] + ':' + str(coin['prevout_n']) in domain_coins)] |
There was a problem hiding this comment.
Good point. Not sure why I was casting there. Removed it.
|
|
|
Otherwise I've tested and it works as expected. :) |
JeremyRand
force-pushed
the
rpc-from-coins
branch
from
928eba3
to
7b91cd9
Compare
@SomberNight Fixed merge conflict. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5430