(WIP) verifier: Get single header when cheaper than chunk #5653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a rough port of abf12b6 by rt121212121 from Electron-Cash.
This makes it easier for Electrum forks to support alternate header formats such as AuxPoW.
Move hash_merkle_root to blockchain.py to avoid circular imports.
JeremyRand
force-pushed
the
cp-height-checkpoints-verifier
branch
from
fe0f0bf
to
1365540
Compare
JeremyRand
changed the title
|
closing as it depends on #5147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #5147 by making the SPV verifier only retrieve single headers if doing so will save bandwidth compared to retrieving full chunks. In my brief performance testing, it improved the delay of verifying a watch-only wallet (using Tor) by around 30%.
It should not be merged until #5147 has been merged and this PR has been rebased accordingly.