CoinChooser: avoid NotEnoughFunds if zero buckets are sufficient #5752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coin chooser incorrectly raises
NotEnoughFunds
when the following conditions are both true whenmake_tx
is called:len(coins) == 0
inputs
is sufficient to fund the transaction.This PR explicitly checks whether an empty bucket is sufficient to fund the transaction, and if so, suppresses the
NotEnoughFunds
.