Proper root init for MemMapFs in windows #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nofun97
changed the title
0xmichalis
reviewed
Mar 27, 2020
0xmichalis
reviewed
Mar 27, 2020
|
rebased and added requested changes |
nofun97
force-pushed
the
feature/proper-root-init-MemMapFs
branch
from
5e4c984
to
f10f855
Compare
0xmichalis
reviewed
Mar 28, 2020
| absolutePath, err := filepath.Abs(FilePathSeparator) | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| panic(err) |
There was a problem hiding this comment.
Is panic needed if you log.Fatal above?
|
This looks like a breaking change so need other folks to chime in and comment on whether it makes sense to have. |
|
See also #171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225
Problem:
MemMapFs is set to initialize with a map data structure and a root path was added to it. The path that was added uses the
os.PathSeparatoras the root path. While UNIX has no problem with this, Windows does as the volume name is not present inos.PathSeparatorChanges:
getData()init is now changed to add a root absolute instead ofFilePathSeparatornormalizePath(path string) stringis changed to return a proper root absolute if the cleaned path results in a root path (/or\\) and an errorName() stringis called to hide real path