Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit LICENSE file when license is set to none #937

Closed
wants to merge 2 commits into from
Closed

Omit LICENSE file when license is set to none #937

wants to merge 2 commits into from

Conversation

rhcarvalho
Copy link

Since the documented purpose of --license none is to have no license, creating a project should not create an empty LICENSE file.

@umarcor umarcor mentioned this pull request Sep 16, 2019
Closed
@jharshman jharshman added this to the 1.0.0 milestone Oct 7, 2019
@umarcor
Copy link
Contributor

umarcor commented Jan 4, 2020

@rhcarvalho, would you mind rebasing thir PR, please?

@rhcarvalho
Write temporary test files in temp directory
748b14c 
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
@rhcarvalho
Omit LICENSE file when licence is set to none
3bba6a2 
Creating a project without a license should not create an empty LICENSE
file.
@rhcarvalho
Copy link
Author

Rebased 🎉

umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
@rhcarvalho @umarcor
write temporary test files in temp directory (spf13#937)
57296e2 
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
@rhcarvalho @umarcor
omit LICENSE file when licence is set to none (spf13#937)
cb9f757 
Creating a project without a license should not create an empty LICENSE
file.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
@rhcarvalho @umarcor
write temporary test files in temp directory (spf13#937)
f8a2118 
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
@rhcarvalho @umarcor
omit LICENSE file when licence is set to none (spf13#937)
6fc2c6e 
Creating a project without a license should not create an empty LICENSE
file.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 3, 2020
@rhcarvalho @umarcor
write temporary test files in temp directory (spf13#937)
9750343 
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 3, 2020
@rhcarvalho @umarcor
omit LICENSE file when licence is set to none (spf13#937)
3c93842 
Creating a project without a license should not create an empty LICENSE
file.
@umarcor umarcor mentioned this pull request Feb 3, 2020
Closed
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 20, 2020
@rhcarvalho @umarcor
write temporary test files in temp directory (spf13#937)
cf8580f 
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 20, 2020
@rhcarvalho @umarcor
omit LICENSE file when licence is set to none (spf13#937)
ce2f0b0 
Creating a project without a license should not create an empty LICENSE
file.
jharshman
jharshman requested changes Feb 26, 2020
View reviewed changes
Copy link
Collaborator

@jharshman jharshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great but please trim the changes down to just the license conditional and the test.

umarcor pushed a commit to umarcor/cobra that referenced this pull request Mar 1, 2020
@rhcarvalho @umarcor
write temporary test files in temp directory (spf13#937)
8b2a7dc 
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Mar 1, 2020
@rhcarvalho @umarcor
omit LICENSE file when licence is set to none (spf13#937)
15ed74b 
Creating a project without a license should not create an empty LICENSE
file.
@rhcarvalho
Copy link
Author

Closing in favor of #1028

@rhcarvalho rhcarvalho closed this Mar 2, 2020
@rhcarvalho rhcarvalho deleted the no-license branch March 2, 2020 17:02
@rhcarvalho rhcarvalho restored the no-license branch March 2, 2020 17:03
umarcor pushed a commit to umarcor/cobra that referenced this pull request Apr 13, 2020
@rhcarvalho @umarcor
write temporary test files in temp directory (spf13#937)
360ea84 
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Apr 13, 2020
@rhcarvalho @umarcor
omit LICENSE file when licence is set to none (spf13#937)
505686f 
Creating a project without a license should not create an empty LICENSE
file.
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 11, 2020
@rhcarvalho @umarcor
write temporary test files in temp directory (spf13#937)
33fadcb 
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 11, 2020
@rhcarvalho @umarcor
omit LICENSE file when licence is set to none (spf13#937)
e527498 
Creating a project without a license should not create an empty LICENSE
file.
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 11, 2020
@rhcarvalho @umarcor
omit LICENSE file when licence is set to none (spf13#937)
04dd57f 
Creating a project without a license should not create an empty LICENSE
file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharshman jharshman jharshman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rhcarvalho @umarcor @jharshman