make x.Parsed() return true after AddGoFlagSet(x) and pflag.Parse() #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some third part lib such as glog use go flag package, and its some actions depends on if goflag.Parsed().
|
|
|
I like it. But what happens if someone is already using the goflag.Parse(nil) trick in their own code. Will calling it again in our code cause them a problem? |
|
Ok, It doesn't seem that goflag cares if you parse more than once. I'll merge. |
This was referenced Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some third party lib such as glog use go flag package, and its some
actions depend on what goflag.Parsed() returns.