Pre-compile nearly all regex patterns #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
commented
Oct 12, 2023
| @@ -64,7 +64,7 @@ def test_sphinxlint_shall_not_pass(file, expected_errors, capsys): | |||
| assert expected_error in out | |||
| number_of_expected_errors = len(expected_errors) | |||
| number_of_reported_errors = len(out.splitlines()) | |||
| assert number_of_expected_errors == number_of_reported_errors | |||
| assert number_of_expected_errors == number_of_reported_errors, f"{number_of_reported_errors=}, {out=}" | |||
There was a problem hiding this comment.
Not an optimisation, but I found this quite helpful for debugging test failures on my first commit in this PR! Happy to take this out if you prefer, though; I accidentally committed it here 😆
ezio-melotti
approved these changes
Oct 12, 2023
|
Thanks for the review @ezio-melotti! Just pushed a couple more changes, if you want to take another quick look over :) |
hugovk
approved these changes
Oct 12, 2023
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these changes makes a signficant difference by itself. But taken together, I measure around a 9% speedup over
maincurrently! Part of #76