Use require_serial: true
as the default for our pre-commit hook, not -j1
#95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have
[--jobs=1]
as the default args for our pre-commit hook. This is problematic, however, as repos that overrideargs
in their.pre-commit-config.yaml
files (such as CPython) have to re-specify-j1
in theirargs
: the value they provide forargs
overrides the default we give here rather than extending it.This PR proposes that we don't give a default value for
args
, and instead give a default value for therequire_serial
key. Testing locally, usingrequire_serial: true
does seem to be slightly slower than using--jobs=1
for me. But the difference is barely perceptible, and I think this is a big usability improvement: it means we don't have to document that, if you're overridingargs
in your.pre-commit.config.yaml
file, you'll need to make sure to add--jobs=1
in your override.