Merge pull request #10178 from stephenfin/issue-10177

Revert "Close #9993: std domain: Allow to refer an inline target via ref role"
sphinx-doc · Mar 27, 2022 · 4a496bf · 4a496bf
2 parents c93b95d + 105c583
commit 4a496bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/sphinx/domains/std.py b/sphinx/domains/std.py
@@ -754,20 +754,18 @@ def process_doc(self, env: "BuildEnvironment", docname: str, document: nodes.doc
                 sectname = clean_astext(title)
             elif node.tagname == 'rubric':
                 sectname = clean_astext(node)
-            elif node.tagname == 'target' and len(node) > 0:
-                # inline target (ex: blah _`blah` blah)
-                sectname = clean_astext(node)
             elif self.is_enumerable_node(node):
                 sectname = self.get_numfig_title(node)
+                if not sectname:
+                    continue
             else:
                 toctree = next(node.findall(addnodes.toctree), None)
                 if toctree and toctree.get('caption'):
                     sectname = toctree.get('caption')
                 else:
                     # anonymous-only labels
                     continue
-            if sectname:
-                self.labels[name] = docname, labelid, sectname
+            self.labels[name] = docname, labelid, sectname
 
     def add_program_option(self, program: str, name: str, docname: str, labelid: str) -> None:
         self.progoptions[program, name] = (docname, labelid)

diff --git a/tests/test_domain_std.py b/tests/test_domain_std.py
@@ -445,12 +445,3 @@ def test_labeled_rubric(app):
     domain = app.env.get_domain("std")
     assert 'label' in domain.labels
     assert domain.labels['label'] == ('index', 'label', 'blah blah blah')
-
-
-def test_inline_target(app):
-    text = "blah _`inline target` blah\n"
-    restructuredtext.parse(app, text)
-
-    domain = app.env.get_domain("std")
-    assert 'inline target' in domain.labels
-    assert domain.labels['inline target'] == ('index', 'inline-target', 'inline target')