-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translated parsed-literals are incorrectly rendered #12287
Comments
Ah, I only notice #12278 now, as I was already working on this while it was posted. |
Hello, @n-peugnet I think this issue and my issue #12278 are duplicates. So it is indeed a bug from Sphinx itself, right? |
Yes. Which one should I close then? |
@picnixz I have linked some issues and PR to this one so I would like to keep it open if possible. |
I closed mine. |
@hwhsu1231 could you try to compile your example docs with my branch to see if you detect any issues? You can install it with the following command (preferably in a virtual env):
|
Hello, @n-peugnet. It works!!! |
Great to hear! Could try to see if you spot any regression in your docs and if so, report it in the associated pull request #12238? |
Hello, @n-peugnet
May I ask What you want me to do with the PR according to this description? (Be more specific) What does "spot any regression in your docs" mean? |
Sorry it was not very explicit. The branch I asked you to test in #12287 (comment) is a development branch where I rework the internals of Sphinx's translation workflow. It is a little bit experimental, and may introduce regressions, compared to the master branch. As you are currently working on translating a large project, it could be interesting for me if you discover translation issues with this branch, that do not exist in the master branch. This way I can fix the issue in my branch and add a regression test to the testsuite, to make sure it does not break in the future. |
Hello, @n-peugnet
So basically, you want me to keep testing my project with the development branch that you gave me, and report any issue about this branch if found, right? (Since I've already tested my project with this branch in this comment, I just wonder whether you want me to do something else.) If so, no problem!! |
Exactly!
Not really, just keep using it, and if possible, if you find an issue, check that it does not also happens on
Thanks :) |
Describe the bug
When adding
'literal-block'
togettext_additional_targets
option, parsed-literals are allowed to be translated.However, when they are translated, they are incorrectly rendered.
I noticed this while working on #12277, and I intend to fix it as part of #12238.
How to Reproduce
Here is a failing test for this bug (it is based on #12277): n-peugnet/sphinx@add-intl-tests...n-peugnet:sphinx:parsed-literal-i18n
Environment Information
Sphinx extensions
No response
Additional context
Current result:
Expected result:
The text was updated successfully, but these errors were encountered: