Fix ValueError popping out in sphinx.ext.napoleon. #10709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's some parts of the code still expecting a StopIteration instead.
|
I'm merging this to get the 5.1.1 release out, but it would be great to add more tests around Napolean, especially given how widely used it is. A |
AA-Turner
pushed a commit
that referenced
this pull request
Jul 25, 2022
There's some parts of the code still expecting a StopIteration instead.
Merged
4 tasks
matthewfeickert
added a commit
to scikit-hep/pyhf
that referenced
this pull request
Jul 26, 2022
…que' (#1925) * Disallow Sphinx v5.1.0 as it introduces an deque error that can be caused by sphinx.ext.napoleon: > Extension error (sphinx.ext.napoleon): > Handler <function _process_docstring at 0x7f43e8361a20> for event 'autodoc-process-docstring' > threw an exception (exception: pop from an empty deque) - This was fixed rapidly in sphinx-doc/sphinx#10709 and so will not be a problem in Sphinx v5.1.1+.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some parts of the code still expecting a StopIteration instead.
Feature or Bugfix
Purpose
Closes #10701; see discussion starting at #9856 (comment).