LaTeX: allow again figure inside seealso, and seealso inside table cell #12598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes sphinx-doc#12594 which emerged because sphinx-doc#12508 had modified seealso and note-like admonitions to use background color and other effects, but the ensuing LaTeX can not work in a table cell without extras. This also fixes unreported issues unrelated to the 7.4.0 release: - (now old style "lightbox") admonitions render badly in tabulary, - "heavybox" admonitions (they are all now but warning et al. were already) cause PDF crash if in tabulary and are rendered badly if in tabular or longtable. - figure in a table cell is not properly separated from immediately preceding text.
|
I will push soon a commit to fix failing test (which fails for rather silly reason that some label stepped by 1 unit due to additional content; but I should have tested beforehand at home). |
# Conflicts: # CHANGES.rst
|
Cheers @jfbu |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12594 which emerged because #12508 had modified seealso and note-like admonitions to use background color and other effects, but the ensuing LaTeX can not work in a table cell without extras.
This also fixes unreported issues unrelated to the 7.4.0 release: