Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8342: Emit a warning if a unknown domain is given for directive or role #8345

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Oct 27, 2020

Feature or Bugfix

  • Feature

Purpose

…or role

Currently, Sphinx mention nothing if users use unknown domain in their
documents (ex. `.. unknown:directive::`, `:unknown:role` and so on).
This starts to warn them to be clear non acceptable mark-ups.

refs: #8342
@tk0miya tk0miya added type:enhancement enhance or introduce a new feature markup domain labels Oct 27, 2020
@tk0miya tk0miya added this to the 4.0.0 milestone Oct 27, 2020
@tk0miya tk0miya merged commit b93aa31 into master Nov 3, 2020
@tk0miya tk0miya deleted the 8342_warning_for_unknown_domain branch November 3, 2020 02:40
lethosor added a commit to DFHack/dfhack that referenced this pull request May 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
domain markup type:enhancement enhance or introduce a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant