Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: AttributeError handling for sphinx.util.inspect.get* is not needed #8799

Merged
merged 4 commits into from
Feb 1, 2021
Merged

refactor: AttributeError handling for sphinx.util.inspect.get* is not needed #8799

merged 4 commits into from
Feb 1, 2021

Commits on Jan 31, 2021

  1. refactor: AttributeError handling for getmro() is not needed 

    Internally, sphinx.util.inspect.getmro() uses `safe_getattr()` with
the `default` keyword.  Therefore it never raises AttributeError even if
the subject raises an error on accessing `__mro__` attribute.

This fixes the wrong its usage.
    @tk0miya
    tk0miya committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    e6f445f View commit details
    Browse the repository at this point in the history

  2. refactor: AttributeError handling for getannotations() is not needed

    @tk0miya
    tk0miya committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    50295f1 View commit details
    Browse the repository at this point in the history

  3. refactor: AttributeError handling for getall() is not needed

    @tk0miya
    tk0miya committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    9c56224 View commit details
    Browse the repository at this point in the history

  4. refactor: AttributeError handling for getslots() is not needed

    @tk0miya
    tk0miya committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    42e491a View commit details
    Browse the repository at this point in the history