ShellCalculation: Resolve escaped curly braces in arguments
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any argument that did not contain a placeholder would simply be appended as is, but this would cause escaped curly braces not to be resolved. The solution is to just call `argument.format()` in this case, letting the string formatter take care of resolving the escaped characters.
sphuber
force-pushed
the
fix/101/expand-escaped-curly-braces-in-arguments
branch
from
87e2f85
to
085efa5
Compare
|
Thanks a lot for the fix! It works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
Any argument that did not contain a placeholder would simply be appended as is, but this would cause escaped curly braces not to be resolved. The solution is to just call
argument.format()in this case, letting the string formatter take care of resolving the escaped characters.