launch_shell_job: Move computer to top-level of metadata
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `metadata` passed to the `launch_shell_job` is just supposed to expose the same input of the `ShellJob` and essentially forward it. However, the `computer` input was expected to be passed nested inside the `options` namespace, even though it is defined as a top-level metadata input. This makes the inputs for `launch_shell_job` dfifferent from the `ShellJob` causing unnecessary confusion. The `computer` input should now be specified as a top-level metadata input for the `launch_shell_job` wrapper as well and passing it nested inside the `metadata.options` is deprecated.
sphuber
force-pushed
the
fix/computer-metadata-option
branch
from
0fbfb68
to
2ab8219
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
metadatapassed to thelaunch_shell_jobis just supposed to expose the same input of theShellJoband essentially forward it. However, thecomputerinput was expected to be passed nested inside theoptionsnamespace, even though it is defined as a top-level metadata input. This makes the inputs forlaunch_shell_jobdfifferent from theShellJobcausing unnecessary confusion. Thecomputerinput should now be specified as a top-level metadata input for thelaunch_shell_jobwrapper as well.