Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(StarryNight): improve visibility of text on artist page and fix occasional missing shooting stars #1112

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
61b7fa0
fix(StarryNight): fix zero playbar width on startup and add instructi…
b-chen00 Apr 19, 2024
e9e2828
Merge branch 'spicetify:master' into master
b-chen00 Apr 24, 2024
0ae5ad2
Added forest green color scheme
jal1077 Apr 24, 2024
dee4a0c
Merge pull request #1 from b-chen00/julissa
b-chen00 Apr 28, 2024
e97ea3d
fixed explicit icon letter E being invisible
b-chen00 May 5, 2024
84d8f50
add several color schemes
b-chen00 May 5, 2024
ab58aee
Added the sunrise theme with orange and yellow
jal1077 May 6, 2024
3a8165a
Added theme with orange and yellow
jal1077 May 6, 2024
14379ed
fixed broken preview image path
b-chen00 May 8, 2024
436469e
Merge branch 'spicetify:master' into master
b-chen00 May 8, 2024
60c8a5b
Merge branch 'master' into julissa
b-chen00 May 8, 2024
d2007ba
Merge pull request #2 from b-chen00/julissa
b-chen00 May 8, 2024
5ab2612
add orange theme and fix broken marketplace preview image path
b-chen00 May 8, 2024
d1e71ae
add orange color scheme to starrynight in themes.md
b-chen00 May 8, 2024
be08974
sort color schemes alphabetically for marketplace color scheme selection
b-chen00 May 8, 2024
5302b83
fix template areas for experimental ui navbar
b-chen00 May 27, 2024
84ba5f4
remove square box shadow that remained from making cover art a circle
b-chen00 May 27, 2024
6a2ffb1
Merge branch 'spicetify:master' into master
b-chen00 May 27, 2024
cf8a03c
attempt to make stars more round instead of a square pixel but might …
b-chen00 May 27, 2024
b5897a2
fix invisible text on button and make some more backgrounds transparent
b-chen00 Aug 22, 2024
6c358e2
fix missing shooting stars
b-chen00 Aug 22, 2024
24cbb7a
remove unnecessary console log
b-chen00 Aug 22, 2024
b31ee17
fix invisible text when hovering search bar
b-chen00 Aug 22, 2024
a769db2
Merge branch 'master' into master
b-chen00 Aug 22, 2024
fc69490
fixed bad merge conflict resolution
b-chen00 Aug 22, 2024
29d6201
fix text visiblity issue on artist page and occasional missing shooti…
b-chen00 Sep 20, 2024
4f35b2a
remove duplicate css rule
b-chen00 Sep 20, 2024
12e5f06
Merge branch 'master' into master
b-chen00 Sep 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions StarryNight/theme.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,24 +77,23 @@ waitForElement(['.Root__top-container'], ([topContainer]) => {

resizeObserver.observe(rightbar);

// start or stop spinning animation based on whether something is playing
const targetElement = document.querySelector('[data-encore-id="buttonPrimary"]');

const playObserver = new MutationObserver((mutationsList, observer) => {
for (const mutation of mutationsList) {
if (
mutation.type === 'attributes' &&
mutation.attributeName === 'aria-label'
) {
handleLabelChange();
waitForElement(['[data-encore-id="buttonPrimary"]'], ([targetElement]) => {
// start or stop spinning animation based on whether something is playing
const playObserver = new MutationObserver((mutationsList) => {
for (const mutation of mutationsList) {
if (
mutation.type === 'attributes' &&
mutation.attributeName === 'aria-label'
) {
handleLabelChange();
}
}
}
});

const playConfig = { attributes: true, attributeFilter: ['aria-label'] };
playObserver.observe(targetElement, playConfig);
});

const playConfig = { attributes: true, attributeFilter: ['aria-label'] };

playObserver.observe(targetElement, playConfig);

function handleLabelChange() {
const img = document.querySelector(
'.main-nowPlayingWidget-coverArt .cover-art img'
Expand Down
23 changes: 10 additions & 13 deletions StarryNight/user.css
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,9 @@
background-color: #00000000 !important;
}

.main-actionBarBackground-background {
background-color: #00000000 !important;
}

.main-home-homeHeader {
background-color: #00000000 !important;
background-image: none !important;
}

.Root__top-container {
Expand Down Expand Up @@ -75,15 +72,19 @@
}

.main-actionBarBackground-background {
background-image: linear-gradient(rgba(var(--spice-rgb-shadow), .6) 0, #000000 100%), #00000000 !important;
background-image: none;
background-color: #00000000 !important;
animation: none !important;
-webkit-animation: none !important;
}

.main-entityHeader-background.main-entityHeader-overlay {
background-image: none !important;
.main-entityHeader-overlay {
background: none !important;
}

.main-entityHeader-background.main-entityHeader-gradient {
opacity: 0.5;
animation: none !important;
-webkit-animation: none !important;
}

.main-entityHeader-background.main-entityHeader-overlay:after {
Expand All @@ -93,7 +94,7 @@
}

.pUNc2aOeOQANHrhYa1GU .RDZ61ETnag1ilfZTkVxe {
color: #000000 !important;
color: #00000000 !important;
}

.playlist-playlist-playlistContent {
Expand Down Expand Up @@ -122,10 +123,6 @@
background-color: #00000000 !important;
}

.main-home-homeHeader {
background-image: linear-gradient(rgba(var(--spice-rgb-shadow), .6) 0, #00000000 100%), var(--background-noise);
}

.main-nowPlayingBar-center {
width: 100%;
}
Expand Down