add macvlan overlay e2e #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
=====================================
Coverage 7.44% 7.44%
=====================================
Files 5 5
Lines 1303 1303
=====================================
Hits 97 97
Misses 1202 1202
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. |
cyclinder
reviewed
Nov 8, 2022
| //if net.ParseIP(v).To4() == nil && !IPV6 { | ||
| if net.ParseIP(v).To4() == nil { | ||
| continue | ||
| } else if net.ParseIP(v).To4() != nil && !IPV4 { |
| multusInstance, err := frame.GetMultusInstance(common.MacvlanOverlayVlan100Name, multuNs) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(multusInstance).NotTo(BeNil()) | ||
| annotations[common.MultusAddonAnnotation_Key] = fmt.Sprintf("%s/%s", multuNs, common.MacvlanOverlayVlan100Name) |
There was a problem hiding this comment.
这里的anotations 应该包括 spiderpool 指定 ip 池的 annotation, 并且选择 vlan100 的IP池
| It("Pod should be access to clusterIP, including ipv4 and ipv6", Label("curl"), func() { | ||
| for _, pod := range podList.Items { | ||
| for _, clusterIP := range clusterIPs { | ||
| if net.ParseIP(clusterIP).To4() == nil { |
There was a problem hiding this comment.
这里留个 todo ，说明 calico ipv6 目前通讯问题，把 projectcalico/calico#6877 链接留下
| It("Host should be access to clusterIP, including ipv4 and ipv6", Label("curl"), func() { | ||
| for _, node := range frame.Info.KindNodeList { | ||
| for _, clusterIP := range clusterIPs { | ||
| if net.ParseIP(clusterIP).To4() == nil { |
There was a problem hiding this comment.
这里留个 todo ，说明 calico ipv6 目前通讯问题，把 projectcalico/calico#6877 链接留下
| It("Host should be access to nodePort address, including ipv4 and ipv6", Label("curl"), func() { | ||
| for _, node := range frame.Info.KindNodeList { | ||
| for _, nodeIP := range nodeIPs { | ||
| if net.ParseIP(nodeIP).To4() == nil { |
There was a problem hiding this comment.
这里留个 todo ，说明 calico ipv6 目前通讯问题，把 projectcalico/calico#6877 链接留下
weizhoublue
reviewed
Nov 9, 2022
| @@ -5,7 +5,7 @@ set -o errexit -o nounset -o pipefail | |||
| #INSTALLED=` helm list -n kube-system --kubeconfig ${E2E_KUBECONFIG} | awk '{print $1}'| grep spiderpool ` | |||
| #[ -n ${INSTALLED} ] && echo "Warning!! spiderpool has been deployed, skip install spiderpool" && exit 0 | |||
|
|
|||
| SPIDERPOOL_VERSION=${SPIDERPOOL_VERSION:-0.2.0} | |||
| SPIDERPOOL_VERSION=${SPIDERPOOL_VERSION:-0.3.2} | |||
There was a problem hiding this comment.
这个 变量，最终 应该是能够在 makefile 中 体现和决定
ii2day
force-pushed
the
main
branch
2 times, most recently
from
149d84e
to
898ea66
Compare
weizhoublue
approved these changes
Nov 13, 2022
|
Host should be access to nodePort address, including ipv4 and ipv6 case 失败了，本地再看看？@Roronoa-Z3r0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.