Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there meaningless fields? #2543

Closed
ty-dc opened this issue Nov 6, 2023 · 1 comment · Fixed by #2544
Closed

Are there meaningless fields? #2543

ty-dc opened this issue Nov 6, 2023 · 1 comment · Fixed by #2544

Comments

@ty-dc
Copy link
Collaborator

ty-dc commented Nov 6, 2023

Spiderpool Version

v0.8.0-rc1

Bug Type

IPAM

Main CNI

macvlan

What happened?

In version 0.7.0 or 0.6.0, we've removed the default subnet feature. ?

And when adjusting the default pool, we use spec.default, which controls the default condition of the pool by true or false.

Therefore, ClusterDefaultIPv4IPPool, ClusterDefaultIPv6IPPool, ClusterDefaultIPv4Subnet, and ClusterDefaultIPv6Subnet in the following configmap are actually meaningless?

	// configmap
	IpamUnixSocketPath                string   `yaml:"ipamUnixSocketPath"`
	EnableIPv4                        bool     `yaml:"enableIPv4"`
	EnableIPv6                        bool     `yaml:"enableIPv6"`
	EnableStatefulSet                 bool     `yaml:"enableStatefulSet"`
	EnableKubevirtStaticIP            bool     `yaml:"enableKubevirtStaticIP"`
	EnableSpiderSubnet                bool     `yaml:"enableSpiderSubnet"`
	ClusterDefaultIPv4IPPool          []string `yaml:"clusterDefaultIPv4IPPool"`
	ClusterDefaultIPv6IPPool          []string `yaml:"clusterDefaultIPv6IPPool"`
	ClusterDefaultIPv4Subnet          []string `yaml:"clusterDefaultIPv4Subnet"`
	ClusterDefaultIPv6Subnet          []string `yaml:"clusterDefaultIPv6Subnet"`
	ClusterSubnetDefaultFlexibleIPNum int      `yaml:"clusterSubnetDefaultFlexibleIPNumber"`

What did you expect to happen?

All work fine.

How to reproduce it (as minimally and precisely as possible)

https://github.com/spidernet-io/spiderpool/blob/main/cmd/spiderpool-agent/cmd/config.go

Additional Context

No response

@Icarus9913
Copy link
Collaborator

Yeah, we already removed the configmap cluster default Subnet/IPPools. So, these fields are useless:

	ClusterDefaultIPv4IPPool          []string `yaml:"clusterDefaultIPv4IPPool"`
	ClusterDefaultIPv6IPPool          []string `yaml:"clusterDefaultIPv6IPPool"`
	ClusterDefaultIPv4Subnet          []string `yaml:"clusterDefaultIPv4Subnet"`
	ClusterDefaultIPv6Subnet          []string `yaml:"clusterDefaultIPv6Subnet"`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants