cleanup: remove configmap obsolete fields #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ty-dc
added
pr/ready-review
ty-dc
requested review from
weizhoublue,
bzsuni and
Icarus9913
as code owners
Signed-off-by: tao.yang <[email protected]>
ty-dc
force-pushed
the
cleanup/remove-default
branch
from
752d563
to
8bd07b9
Compare
|
You should also delete |
Codecov Report
@@ Coverage Diff @@
## main #2544 +/- ##
==========================================
+ Coverage 80.87% 80.93% +0.05%
==========================================
Files 49 49
Lines 5303 5303
==========================================
+ Hits 4289 4292 +3
+ Misses 857 855 -2
+ Partials 157 156 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Icarus9913
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
kind/cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
close #2543
Special notes for your reviewer:
Signed-off-by: ty-dc [email protected]