Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize the autopool name length to 253 #2177

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

Icarus9913
Copy link
Collaborator

Refer to DNS (RFC 1123), the subdomain's max length is 253. But we made mistake and regard it as length 63.
Actually the finalizer name, annotation key and label key max length is 63

Signed-off-by: Icarus9913 [email protected]

@Icarus9913 Icarus9913 added pr/release/none-required pr/ready-review This pull is ready for review enhancement source codes enhancement cherrypick-release-v0.6 Cherry-pick the PR to branch release-v0.6. labels Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #2177 (7de69b1) into main (71c15e0) will decrease coverage by 0.52%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
- Coverage   81.68%   81.17%   -0.52%     
==========================================
  Files          49       49              
  Lines        5210     5210              
==========================================
- Hits         4256     4229      -27     
- Misses        792      823      +31     
+ Partials      162      158       -4     
Flag Coverage Δ
unittests 81.17% <ø> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...pplicationcontroller/applicationinformers/utils.go 85.75% <ø> (ø)

... and 1 file with indirect coverage changes

@weizhoublue weizhoublue merged commit e092177 into spidernet-io:main Aug 10, 2023
37 checks passed
@Icarus9913 Icarus9913 deleted the fix/wk/autopool-name-len branch August 14, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick-release-v0.6 Cherry-pick the PR to branch release-v0.6. enhancement source codes enhancement pr/ready-review This pull is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants