Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent can be set rp_filter to 0 for each node #3908

Merged

Conversation

cyclinder
Copy link
Collaborator

Thanks for contributing!

What type of PR is this?

  • release/feature

What this PR does / why we need it:

agent can be set rp_filter to 0 for each node by default

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (ac18f55) to head (5d89444).
Report is 2 commits behind head on release-v1.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release-v1.0    #3908   +/-   ##
=============================================
  Coverage         81.16%   81.16%           
=============================================
  Files                50       50           
  Lines              4391     4391           
=============================================
  Hits               3564     3564           
  Misses              670      670           
  Partials            157      157           
Flag Coverage Δ
unittests 81.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cyclinder
Copy link
Collaborator Author

• [FAILED] [300.690 seconds]
test reliability [reliability]
/home/runner/work/spiderpool/spiderpool/test/e2e/reliability/reliability_test.go:21
  reliability test table
  /home/runner/work/spiderpool/spiderpool/test/e2e/reliability/reliability_test.go:54
    [It] Successfully run a pod during the Spiderpool controller is restarting [R00001, G00008]

@cyclinder cyclinder force-pushed the cherry_pick_1.0_sysctl_rpfilter branch from da523cd to 5d89444 Compare August 20, 2024 07:51
@cyclinder cyclinder requested a review from bzsuni as a code owner August 20, 2024 07:51
@cyclinder cyclinder merged commit c1ec2e0 into spidernet-io:release-v1.0 Aug 20, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/feature-new release note for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants