Bump Go to 1.21 #277
Merged
Bump Go to 1.21 #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Turner <[email protected]>
rturner3
requested review from
amartinezfayo,
evan2645 and
azdagron
as code owners
added 6 commits
March 31, 2024 22:28
Signed-off-by: Ryan Turner <[email protected]>
Signed-off-by: Ryan Turner <[email protected]>
Signed-off-by: Ryan Turner <[email protected]>
Signed-off-by: Ryan Turner <[email protected]>
Signed-off-by: Ryan Turner <[email protected]>
Signed-off-by: Ryan Turner <[email protected]>
azdagron
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of
github.com/go-jose/go-josedepends on Go 1.21+. Since Go 1.21 has been released since March 2023, it should be safer to use it for building/testing code in the repo.Also bump
golangci-lintto latest version 1.57.2, as the older version used in the repo is incompatible with Go 1.21+. Some additional changes to make the lint build pass:depchecklinter that was previously enabled, but not configured. It now causes the lint build to fail since no dependencies are configured in the allowlist.unused-parameterrule inrevivelinter, since naming parameters can be helpful for documentation purposes in libraries.golangci-lintconfig that was moved in newer versions.fakeworkloadapithat was depending on a deprecatedrand.Seed()method as well as a weak random number generator frommath/rand.