Add testParseJWKSWithEmptyKeysArray
#233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Lambrecht <[email protected]>
rturner3
approved these changes
Oct 7, 2024
| TrustDomain trustDomain = TrustDomain.parse("example.org"); | ||
| String jwksEmptyKeysJson = "{\"keys\": []}"; | ||
| byte[] bundleBytes = jwksEmptyKeysJson.getBytes(StandardCharsets.UTF_8); | ||
|
|
There was a problem hiding this comment.
Suggested change
nit: extra whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Introduces a unit test for
JwtBundle.parseto verify correct handling of JWKS documents with an empty keys array, ensuring our parsing logic handles such edge cases without errors. This addition improves the reliability of our JWKS processing against unusual but valid JWKS configurations.