Remove extraneous comment in proto file #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisgove
requested review from
evan2645,
amartinezfayo,
azdagron and
rturner3
as code owners
dennisgove
force-pushed
the
patch-1
branch
3 times, most recently
from
4eae2b9
to
d330699
Compare
|
Thanks for this @dennisgove. Can you rebase this on top of the next branch and change the PR target for that branch instead of https://github.com/spiffe/spire-api-sdk/blob/main/CONTRIBUTING.md#opening-prs |
Remove what appears to be a copy/paste error in the comment for rpc SubscribeToX509Bundles(...). The removed text appears to be copied from rpc SubscribeToX509SVIDs(...) but is irrelevant in the current context. Signed-off-by: Dennis Gove <[email protected]>
|
Sorry about that. I started the change in the GH UI and it pulled from |
|
No a problem! The policy is really hard to discover... we need to improve that. |
azdagron
approved these changes
Oct 17, 2024
MarcosDY
pushed a commit
to MarcosDY/spire-api-sdk
that referenced
this pull request
Oct 21, 2024
Remove what appears to be a copy/paste error in the comment for rpc SubscribeToX509Bundles(...). The removed text appears to be copied from rpc SubscribeToX509SVIDs(...) but is irrelevant in the current context. Signed-off-by: Dennis Gove <[email protected]>
MarcosDY
pushed a commit
that referenced
this pull request
Oct 21, 2024
Remove what appears to be a copy/paste error in the comment for rpc SubscribeToX509Bundles(...). The removed text appears to be copied from rpc SubscribeToX509SVIDs(...) but is irrelevant in the current context. Signed-off-by: Dennis Gove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove what appears to be a copy/paste error in the comment for
rpc SubscribeToX509Bundles(...). The removed text appears to be copied fromrpc SubscribeToX509SVIDs(...)but is irrelevant in the current context.