Some update #2
Open
Some update #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support multi device Clear code
|
Hi, thanks a lot for making a PR, it's awesome! From a quick look, your PR seems to be doing more than one thing, and perhaps part of it might be too specific to your use case (those baud settings imply you're talking to a serial device). I don't mind being specific, but I think it's better if I refrain from merging anything here now and anyone interested can pick up the changes from your branch. If there's another small PR that changes one thing with a clear explanation of what the change affects so I can try to follow it, I'll consider merging it here. If you decide to maintain a project for general use, by all means take over the task in your fork! |
added 2 commits
May 23, 2019 14:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Win7
Support add new device
Clear code
#1