Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(awscli): Bump AWS CLI and fix install of AWS CLI #5995

Merged
merged 6 commits into from
Aug 24, 2023
Merged

chore(awscli): Bump AWS CLI and fix install of AWS CLI #5995

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f716208
chore(awscli): Bump AWS CLI and fix install of AWS CLI
jasonmcintosh Aug 16, 2023
f67c0d1
chore(upgrade): Upgrade Ubuntu image to latest supported release
jasonmcintosh Aug 16, 2023
b7ea84d
chore(awscli): Ubuntu docker image bump in separate PR revert to mast…
jasonmcintosh Aug 16, 2023
879e515
Merge branch 'fixAwsCli' of github.com:armory-io/clouddriver into fix…
jasonmcintosh Aug 16, 2023
b9489d1
chore(awscli): Ubuntu docker image bump in separate PR revert to mast…
jasonmcintosh Aug 16, 2023
330bedf
Merge branch 'master' into fixAwsCli
jasonmcintosh Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ARG TARGETARCH

# KUBECTL_RELEASE kept one minor version behind latest to maximise compatibility overlap
ENV KUBECTL_RELEASE=1.22.17
ENV AWS_CLI_VERSION=1.18.152
ENV AWS_CLI_VERSION=1.22
ENV AWS_CLI_S3_CMD=2.0.2
ENV AWS_AIM_AUTHENTICATOR_VERSION=0.5.9
ENV GOOGLE_CLOUD_SDK_VERSION=412.0.0
Expand All @@ -23,7 +23,7 @@ RUN apk update \
openssh-client

# AWS CLI
RUN pip install --upgrade awscli==${AWS_CLI_VERSION} s3cmd==${AWS_CLI_S3_CMD} python-magic \
RUN pip install --upgrade --no-build-isolation awscli==${AWS_CLI_VERSION} s3cmd==${AWS_CLI_S3_CMD} python-magic \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does --no-build-isolation do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand, it prevents some automatic install of some dependencies:
https://stackoverflow.com/questions/62889093/what-does-no-build-isolation-do/62889267#62889267

This was the recommended flag from AWS to get the CLI install working. Whether it's "right" is a different question.
I'll bet testing more shortly BUT getting this out here now while I do that testing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's broken about the way it is without -no-build-isolation ? We're not using it and haven't seen any problems -- though there could totally still be some.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional notes: this seems to be dependent upon which version of python & libs. AKA builds failed on ubuntu. Ubuntu bionic is out of standard support so this MAY not be required UNTIl we start other upgrades.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What breaks is the pip install. Will NOT impact any EXISTING built images and It's PRIMARILY impacting Alpine builds - started in July? due to a dependency of the aws cli pip install. Bionic may not have the issue but bionic is WAY out of date, testing that as well in this. Will LIKELY revert the bionic and do a separate PR with JUST the ubuntu changes.

&& pip uninstall -y pip

# Google cloud SDK
Expand Down