Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow synthetic default imports #7670

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Allow synthetic default imports #7670

merged 2 commits into from
Dec 10, 2019

Conversation

christopherthielen
Copy link
Contributor

Enables allowSyntheticDefaultImports and allowJs.

Typescript 3.7 now supports allowJs and declarations at the same time.
microsoft/TypeScript#7546

allowSyntheticDefaultImports lets us do the normal javascript style import import foo from 'foo' instead of import * as foo from 'foo'

@christopherthielen
Copy link
Contributor Author

Depends on #7668

@christopherthielen
feat(typescript): enable allowJs and allowSyntheticDefaultImports
0077c7e 
 - allowJs allows typescript to check javascript files and ES6 import from javascript without a .d.ts file
 - allowSyntheticDefaultImports allows us to `import React from 'react'`
@christopherthielen
chore(typescript): Migrate most wildcard imports to javascript style …
b002524 
…imports

- Migrate from "import * as foo from 'foo'" to "import foo from 'foo'"
@christopherthielen christopherthielen added the ready to rebase Reviewed and ready to rebase and merge label Dec 9, 2019
@mergify mergify bot merged commit b6aabe1 into spinnaker:master Dec 10, 2019
@mergify mergify bot added the auto merged Merged automatically by a bot label Dec 10, 2019
@christopherthielen christopherthielen deleted the allow-synthetic-default-imports branch December 10, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisjimenez louisjimenez louisjimenez approved these changes

@alanmquach alanmquach Awaiting requested review from alanmquach

@erikmunson erikmunson Awaiting requested review from erikmunson

@maggieneterval maggieneterval Awaiting requested review from maggieneterval

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to rebase Reviewed and ready to rebase and merge target-release/1.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christopherthielen @louisjimenez @spinnakerbot