feat(build): Add custom rollup config for core #9297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigneshm
force-pushed
the
core-rollup-config
branch
from
f0ac239
to
0a9984e
Compare
christopherthielen
approved these changes
Jun 4, 2021
vigneshm
force-pushed
the
core-rollup-config
branch
from
0a9984e
to
3f331a7
Compare
The `core` package has some unique characteristics that need a custom rollup config file rather than using the generic one from `@spinnaker/scripts`. This includes - copying over typescript definition files - defining an alias mapping for `root` - a plugin to fix typescript's path auto-rewrites.
vigneshm
force-pushed
the
core-rollup-config
branch
from
3f331a7
to
8a06319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9295
The
corepackage has some unique characteristics that need a custom rollup config file rather than using the generic one from@spinnaker/scripts. This includesroot