Improve CycleOrmBootloader bindings

[kafkiansky]

Made the EntityManagerInterface a singleton, so that the persist and run operations could be called independently of each other and the operations on the entity were performed. Also, instead of clearing the heap with ORMInterface, did it using the EntityManagerInterface::clean method.

But I find it a bit strange that the EntityManager has an argument $cleanHeap in the clean method that is not in the EntityManagerInterface. IMHO, it should not be in EntityManager at all, so both heap and entity manager should be called in the finalizer as follows:

$finalizer->addFinalizer(
    static function () use ($container): void {
       if ($container->hasInstance(EntityManagerInterface::class)) {
           $container->get(EntityManagerInterface::class)->clean();
       }

       if ($container->hasInstance(ORMInterface::class)) {
           $container->get(ORMInterface::class)->getHeap()->clean();
       }
});

And EntityManager should only create a new UnitOfWork instance:

public function clean(): static
{
      $this->unitOfWork = new UnitOfWork($this->orm);

      return $this;
}

[codecov]

Codecov Report

Base: 67.84% // Head: 69.17% // Increases project coverage by +1.33% 🎉

Coverage data is based on head (cf533fb) compared to base (a018fba).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff              @@
##             master      #33      +/-   ##
============================================
+ Coverage     67.84%   69.17%   +1.33%     
- Complexity      435      436       +1     
============================================
  Files            52       52              
  Lines          1132     1275     +143     
============================================
+ Hits            768      882     +114     
- Misses          364      393      +29     

Impacted Files	Coverage Δ
src/Bootloader/CycleOrmBootloader.php	100.00% <100.00%> (+3.84%)	⬆️
.../DataGrid/Specification/Sorter/InjectionSorter.php	57.14% <0.00%> (-0.76%)	⬇️
...Console/Command/CycleOrm/Generator/ShowChanges.php	60.97% <0.00%> (-0.57%)	⬇️
src/polyfill.php	0.00% <0.00%> (ø)
src/Schema/Compiler.php	100.00% <0.00%> (ø)
src/Bootloader/CommandBootloader.php	100.00% <0.00%> (ø)
src/Interceptor/CycleInterceptor.php	100.00% <0.00%> (ø)
src/Bootloader/DataGridBootloader.php	100.00% <0.00%> (ø)
src/Bootloader/DatabaseBootloader.php	100.00% <0.00%> (ø)
src/DataGrid/Writer/BetweenWriter.php	100.00% <0.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[butschster]

@kafkiansky Hi!

Sorry for long response. Could you fix error with static analysis?

[kafkiansky]

@butschster, Hi. I fixed it.

[butschster]

@butschster, Hi. I fixed it.

Thank you! You are the best!

[roxblnfk]

Can you add the second test please with EM mock?

• bindSingleton(EntityManagerInterface::class => mock(EntityManagerInterface::class))
• run $this->getContainer()->get(FinalizerInterface::class)->finalize();
• check the method clean has been called