Filter mask #1327
Merged
Filter mask #1327
+403
−484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatesn
commented
Nov 16, 2024
| @@ -89,6 +90,18 @@ impl Canonical { | |||
| } | |||
| } | |||
|
|
|||
| impl Canonical { | |||
| // Create an empty canonical array of the given dtype. | |||
| pub fn empty(dtype: &DType) -> VortexResult<Canonical> { | |||
robert3005
requested changes
Nov 16, 2024
| @@ -1,3 +1,4 @@ | |||
| #![feature(once_cell_try)] | |||
There was a problem hiding this comment.
in other places we use the once_cell crate to get this feature without requiring one more nightly flag.
There was a problem hiding this comment.
Yeah let's chat Monday, there might be some convergence. I also want to make FilterMask internally memoize the indices or slices, instead of necessarily a boolean buffer.
robert3005
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a memoized filter mask.
FLUPs:
iter()function that returns an Enum of slices or indices based on selectivity. This forces all consumers to support both.