Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RowMasks use bitmasks instead of bitmaps #1346

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RowMasks use bitmasks instead of bitmaps #1346

wants to merge 2 commits into from
+219 −145

Conversation

robert3005
Copy link
Member

No description provided.

@robert3005
Copy link
Member Author

robert3005 commented Nov 18, 2024 •
edited
Loading

there's still something incorrect with the implementation but I will debug that tomorrow

@robert3005 robert3005 enabled auto-merge (squash) November 18, 2024 12:41
@danking
Copy link
Member

danking commented Nov 18, 2024

@robert3005 this looks fine to me. auto-merge is on. is there still something you think is wrong?

@robert3005
Copy link
Member Author

Apologies, I have fixed the issues that made CI red

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwwmanning lwwmanning Awaiting requested review from lwwmanning

@danking danking Awaiting requested review from danking

@gatesn gatesn Awaiting requested review from gatesn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert3005 @danking @lwwmanning