feat: use VarBinView as the new canonical string type #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think apache/arrow-rs#6366 is going to make python tests fail |
|
Yea, even bumping PyArrow from 15 -> 17 (latest) did not seem to change that |
|
Blocked on apache/arrow-rs#6368 |
|
Converting back to draft while this is blocked |
|
I think with arrow 53.1.0 this is no longer blocked |
Time for a take3 PR 🥲 |
|
git cli is a lot smarter than github ui but probably still hard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplants #476.
VarBinView is the new canonical representation for string types across the repo. There are still many places that natively use VarBin arrays internally, we can replace those over time.
Canonical::VarBin->Canonical::VarBinView