Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutable strings #17

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Immutable strings #17

merged 4 commits into from
Sep 4, 2023

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented Sep 4, 2023

I was mistaken in #6 - strings are in fact immutable but the (undocumented) PyUnicode_Append function steals a reference to the LHS.

@gatesn gatesn merged commit 8b04b98 into develop Sep 4, 2023
1 check passed
@gatesn gatesn deleted the ngates/strings branch September 4, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delta003 delta003 delta003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatesn @delta003