Support iterator protocol #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta003
commented
Sep 7, 2023
pydust/src/pytypes.zig
Outdated
Comment on lines
224
to
230
| if (@typeInfo(returnType) == .ErrorUnion) { | ||
| const optional_result = result catch return null; | ||
| const non_optional_result = optional_result orelse return null; | ||
| return (trampoline.wrap(non_optional_result) catch return null).py; | ||
| } | ||
| const non_optional_result = result orelse return null; | ||
| return (trampoline.wrap(non_optional_result) catch return null).py; |
There was a problem hiding this comment.
There is some additional unpacking here cause next can return null as valid - to stop iteration
There was a problem hiding this comment.
I think having a separate tp_iternext_internal function that can return errors might be useful?
robert3005
reviewed
Sep 7, 2023
robert3005
reviewed
Sep 7, 2023
gatesn
reviewed
Sep 7, 2023
pydust/src/pytypes.zig
Outdated
Comment on lines
224
to
230
| if (@typeInfo(returnType) == .ErrorUnion) { | ||
| const optional_result = result catch return null; | ||
| const non_optional_result = optional_result orelse return null; | ||
| return (trampoline.wrap(non_optional_result) catch return null).py; | ||
| } | ||
| const non_optional_result = result orelse return null; | ||
| return (trampoline.wrap(non_optional_result) catch return null).py; |
There was a problem hiding this comment.
I think having a separate tp_iternext_internal function that can return errors might be useful?
|
Addressed |
gatesn
reviewed
Sep 7, 2023
Co-authored-by: Nicholas Gates <[email protected]>
robert3005
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.