Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ADDON-66599 deprecate splunk-hec-token default value and break test execution on exception #804

Merged
merged 6 commits into from
Dec 11, 2023
Merged

fix: ADDON-66599 deprecate splunk-hec-token default value and break test execution on exception #804

merged 6 commits into from
Dec 11, 2023

Conversation

mkolasinski-splunk
Copy link
Contributor

@mkolasinski-splunk mkolasinski-splunk commented Dec 6, 2023 •
edited
Loading

  • deprecate default value of splunk-hec-token - give a warning when it's used
  • add console handler to logger - warnings and errors beside being logged to pytest_splunk_addon.log are also logged to console
  • other minor refactors from PR-803

References:
https://splunk.atlassian.net/browse/ADDON-66599
https://github.com/splunk/pytest-splunk-addon/pull/803/files

@mkolasinski-splunk mkolasinski-splunk changed the title fix: break test execution when first exception occurs, provide a warn… fix: DDON-66599 deprecate splunk-hec-token default value and break test execution on exception Dec 6, 2023
@mkolasinski-splunk mkolasinski-splunk changed the title fix: DDON-66599 deprecate splunk-hec-token default value and break test execution on exception fix: ADDON-66599 deprecate splunk-hec-token default value and break test execution on exception Dec 6, 2023
@mkolasinski-splunk mkolasinski-splunk changed the base branch from main to develop December 6, 2023 08:22
@mkolasinski-splunk mkolasinski-splunk marked this pull request as ready for review December 6, 2023 08:23
@mkolasinski-splunk mkolasinski-splunk merged commit 00755b5 into develop Dec 11, 2023
34 of 35 checks passed
@mkolasinski-splunk mkolasinski-splunk deleted the fix/splunk-hec-token branch December 11, 2023 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 5.2.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artemrys artemrys artemrys approved these changes

@mbruzda-splunk mbruzda-splunk mbruzda-splunk approved these changes

@kdoroszko-splunk kdoroszko-splunk Awaiting requested review from kdoroszko-splunk

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkolasinski-splunk @srv-rr-github-token @artemrys @mbruzda-splunk