Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.11.0 #62

Merged
merged 35 commits into from
Jul 28, 2021
Merged

Release 0.11.0 #62

merged 35 commits into from
Jul 28, 2021

Conversation

akaila-splunk
Copy link
Contributor

  • Update all dependencies to latest stable version and replace deprecated dependencies
  • make library compatible with node version 10.0 and 14.0 and Splunk version 8.0 and 8.2.0
  • Configured GitHub action for test and release
  • Update library to use 'make up' and 'make test' convention

PKing70 and others added 30 commits April 11, 2019 10:34
@PKing70
Revise README
8a74c3d 
Add NodeJS and Splunk versions tested for compatibility
https://jira.splunk.com/browse/DVPL-7485
Merge pull request #27 from PKing70/patch-1
9d0d094 
Revise README
update CI password
2064411
@dependabot
Bump handlebars from 4.0.12 to 4.5.3
06a624a 
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.0.12 to 4.5.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](handlebars-lang/handlebars.js@v4.0.12...v4.5.3)

Signed-off-by: dependabot[bot] <[email protected]>
Merge pull request #36 from splunk/dependabot/npm_and_yarn/handlebars…
9f946d7 
…-4.5.3

Bump handlebars from 4.0.12 to 4.5.3
@PKing70
Update CONTRIBUTING.md
b132814 
Revise link to contact us (no more [email protected]).
@ashah-splunk
Dependency upgrades with Project updated to use Make with Splunk dock…
376f1ec 
…er instance

Dockerized make up, make test commands for local and CI -- makefile, docker-compose.yml, test_specific.sh
Upgraded dependencies
Replaced deprecated dependencies such as "request" and "istanbul" with "needle" and "nyc"
@ashah-splunk
Merge pull request #57 from splunk/DVPL-9451
188c835 
Dependency upgrades with Project updated to use Make with Splunk docker instance
As discussed, merging this PR based on one Approval
@ashah-splunk
Configuring GitHub Actions
48bda96 
GitHub actions for Test execution
@ashah-splunk
Update test.yml
e969375 
Extra on property
@ashah-splunk
Update test.yml
c9669ed
@ashah-splunk
Update test.yml
2d0a59c
@ashah-splunk
Update test.yml
c79d3d8 
Trying with passing value to makefile
@ashah-splunk
Update test.yml
5634638
@ashah-splunk
Update test.yml
5db000c
@ashah-splunk
Update test.yml
8d26be2
@ashah-splunk
Port mapping
6b27089
@ashah-splunk
Update test.yml
5736220
@ashah-splunk
Update test.yml
3600c56
@ashah-splunk
revert test.yml
a1e160b
@ashah-splunk
Update test.yml
1fc1684
@ashah-splunk
Update test.yml
17fabb6
@ashah-splunk
Revert docker compose
da09227
@ashah-splunk
Update test_send.js
bbe057d
@akaila-splunk
Configured release to NPM
4fbd774 
- Testing release to NPM using GitHub action for v0.0.1-beta
@fantavlik
Merge pull request #59 from splunk/DVPL-9453
cebdda9 
Configured GitHub Action for Test Execution
@akaila-splunk
Updated release type to published
ae0837a
@ashah-splunk
Merge pull request #60 from splunk/DVPL-9454
63c539d 
Configured GitHub actions for release to NPM
@fantavlik
Merge pull request #38 from splunk/pking-dvpl-7677
478a4e8 
Update CONTRIBUTING.md
@ashah-splunk
CREDITS.md file addition
0d356d0
fantavlik
fantavlik requested changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, I left comments in the review but two things to take care of:

  • Need to add a new section to the CHANGELOG.md for this new release (notes on what to add to various sections are in the review below)
  • Let's remove the .travis.yml since that's no longer used

splunklogger.js
@@ -14,7 +14,7 @@
* under the License.
*/

var request = require("request");
var needle = require("needle");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's add an item to the CHANGELOG.md for this - under New features & APIs: Replaced client implementation to use needle in lieu of deprecated request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated CHANGELOG.md file as suggested.

.github/workflows/release.yml
@@ -0,0 +1,20 @@
name: Create Release
Copy link
Contributor

@fantavlik fantavlik Jul 26, 2021 •
edited by akaila-splunk
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's add an item to the CHANGELOG.md for this - under Minor changes: Converted CI from Travis to Github Actions and added CD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated CHANGELOG.md file as suggested.

.travis.yml Outdated
@@ -10,7 +10,7 @@ before_install:
# Create .splunkrc file with default credentials
- echo host=localhost >> $HOME/.splunkrc
- echo username=admin >> $HOME/.splunkrc
- echo password=changeme >> $HOME/.splunkrc
- echo password=changed! >> $HOME/.splunkrc
# Set SPLUNK_HOME
- export SPLUNK_HOME="/opt/splunk"
# Pull docker image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the .travis.yml file actually? Feel free to do that in this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed .travis.yml flie.

@akaila-splunk
Copy link
Contributor Author

Looking good so far, I left comments in the review but two things to take care of:

  • Need to add a new section to the CHANGELOG.md for this new release (notes on what to add to various sections are in the review below)
  • Let's remove the .travis.yml since that's no longer used

Updated CHANGELOG.md file as suggested and removed .travis.yml file.

fantavlik
fantavlik approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks again!

@ashah-splunk ashah-splunk merged commit 28f1f51 into master Jul 28, 2021
@akaila-splunk akaila-splunk deleted the release/0.11.0 branch July 28, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantavlik fantavlik fantavlik approved these changes

@zenmoto zenmoto Awaiting requested review from zenmoto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akaila-splunk @fantavlik @ashah-splunk @PKing70