feat: adds transferMultipleSpore and meltMultipleThenCreateSpore
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashuralyk
reviewed
Jul 25, 2024
| } | ||
| } | ||
|
|
||
| return txSkeleton; |
There was a problem hiding this comment.
I recommend to follow its single version that returns transaction skeleton with transferred spore cells index in inputs and outputs
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This PR adds a
Multiple-variants for functiontransferSpore,meltThenCreateSpore, brings the ability to operate multiple Spore assets in a single compacted transaction.Also adds the necessary unit test for these two function.
About Fee payments behavior
I've also checked and fixed the fee payment part of the original
meltThenCreateSpore.The Zero-Fee feature will only happens if:
[inputs.capacity]is greater than[outputs.capacity][inputs.capacity] - [outputs.capacity]is greater than minimal current on-chain fee-rate