Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]! Update to support newer k6 #5

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[feat]! Update to support newer k6 #5

merged 1 commit into from
Sep 13, 2024

Conversation

raven-txm
Copy link
Contributor

Metrics were being refactored around the era of k6 0.40.0, and with 0.41 a breaking change was made that requires code updates to use.

This change updates the code in order to work with 0.41 and newer versions of k6, at the cost of breaking compatability with 0.40 and older versions of k6.

Since the current version of k6 is 0.53.0 at the time of writing, we don't feel like this is too onerous.

Note:

Metrics were being refactored around the era of k6 0.40.0, and with 0.41
a breaking change was made that requires code updates to use.

This change updates the code in order to work with 0.41 and newer
versions of k6, at the cost of breaking compatability with 0.40 and
older versions of k6.

Since the current version of k6 is 0.53.0 at the time of writing, we
don't feel like this is too onerous.

Note:
- Open Telemetry is pinned to 0.24 instead of 0.28 / 0.30 used in k6
  0.53 due to build issues. See
  grafana/k6#3897
Copy link
Contributor

@Xaeroxe Xaeroxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raven-txm raven-txm merged commit 7e36aae into main Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants