Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package with the new DownloadOnlyWhenRequired manifest entry #958

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

gtoison
Copy link
Contributor

@gtoison gtoison commented Feb 2, 2024

@@ -420,6 +420,7 @@
<pluginDescription>Analyze Java, Scala, Closure and JSP code with SpotBugs. ${spotbugs.version}</pluginDescription>
<pluginClass>org.sonar.plugins.findbugs.FindbugsPlugin</pluginClass>
<useChildFirstClassLoader>false</useChildFirstClassLoader>
<requiredForLanguages>java,scala,jsp,clojure,kotlin</requiredForLanguages>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @agigleux
Would you mind confirming that this is correct? Reading the annoucment post it was not 100% clear to me if I should have the languages here or the file extensions for the corresponding languages (for instance kotlin or kt)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be the language keys, so it should be fine like this.

SonarQube 10.4 was released, so it would be great if you could test it with the feature enabled (it is disabled by default in 10.4) to be 100% sure there are no unexpected side effects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming! The integration tests are now running on SonarQube 10.4 and I've also added this to the orchestrator installing the servers (for the integration tests):
.setServerProperty("sonar.plugins.downloadOnlyRequired", "true")

@gtoison gtoison merged commit 155a652 into spotbugs:master Feb 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "sonar-findbugs" compatible with SonarQube 10.4 "DownloadOnlyWhenRequired" feature
2 participants