You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
I found an inconsistent bug description on EQ_COMPARING_CLASS_NAMES.
The description mentioned that “This method checks to see if two objects are the same class by checking to see if the names of their classes are equal” so one would expect SpotBugs to give a warning in the statement if(c.getClass().getName().equals(config.getClass().getName())). However, SpotBugs did not give any warning because its implementation actually checks if the compare statement is inside the equals method according to line 336 in OverridingEqualsNotSymmetrical.java
When we compare the bug description for this pattern and other related patterns, we think that the description should be
changed to “This class defines an equals method that...”
The text was updated successfully, but these errors were encountered:
gloNelson
added a commit
to gloNelson/spotbugs
that referenced
this issue
Apr 22, 2021
Hi,
I found an inconsistent bug description on
EQ_COMPARING_CLASS_NAMES
.The description mentioned that “This method checks to see if two objects are the same class by checking to see if the names of their classes are equal” so one would expect SpotBugs to give a warning in the statement if(c.getClass().getName().equals(config.getClass().getName())). However, SpotBugs did not give any warning because its implementation actually checks if the compare statement is inside the equals method according to line 336 in OverridingEqualsNotSymmetrical.java
When we compare the bug description for this pattern and other related patterns, we think that the description should be
changed to “This class defines an equals method that...”
The text was updated successfully, but these errors were encountered: