Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: is it supported to use requirements files w/ dh_virtualenv --preinstall #292

Open
benbariteau opened this issue Jan 21, 2020 · 6 comments

Comments

@benbariteau
Copy link

It turns out that this workflow is useful to me and I noticed that it works, since this just gets passed to pip. However, I don't know if this is an interface that I can rely on.

@benbariteau
Copy link
Author

I basically do this fyi:

dh_virtualenv --preinstall=-rrequirements-bootstrap.txt ...

@jhermann
Copy link
Contributor

Works in other software like tox, and should be documented with the option. NOT using a space after -r should also be made explicit (makes this more robust against passing in argv arrays).

@nailor
Copy link
Collaborator

nailor commented Jan 22, 2020

I'm all in for supporting this behaviour. Should probably be documented with the --preinstall flag (including the caveats that @jhermann pointed out)

@benbariteau
Copy link
Author

Awesome! Since it uses pip, doing --preinstall='-r requirements-bootstrap.txt' fails with an error about no file named " requirements-bootstrap.txt" lol, so documenting might not be necessary.

@nailor
Copy link
Collaborator

nailor commented Jan 23, 2020 via email

@jhermann
Copy link
Contributor

BTW, I always use -r./foo.txt to make it more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants