Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make function not access outer-state #265

Merged
merged 4 commits into from
Feb 11, 2023
Merged

Make function not access outer-state #265

merged 4 commits into from
Feb 11, 2023

Conversation

live-wire
Copy link
Contributor

  • Minor refactor to use functionality upstream

@live-wire live-wire changed the title WIP: Make function not access outer-state Make function not access outer-state Feb 7, 2023
@live-wire live-wire marked this pull request as ready for review February 7, 2023 15:30
regadas
regadas requested changes Feb 8, 2023
View reviewed changes
pkg/flink/handler.go Outdated Show resolved Hide resolved
@live-wire
Copy link
Contributor Author

@regadas made the suggested changes 👍
Please have a look

regadas
regadas reviewed Feb 11, 2023
View reviewed changes
pkg/flink/handler.go Outdated Show resolved Hide resolved
regadas
regadas reviewed Feb 11, 2023
View reviewed changes
pkg/flink/handler.go Outdated Show resolved Hide resolved
regadas
regadas approved these changes Feb 11, 2023
View reviewed changes
Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@regadas regadas merged commit 31b7063 into master Feb 11, 2023
@regadas regadas deleted the live-wire/refactor-ffp branch February 11, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regadas regadas regadas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@live-wire @regadas