Skip to content

Commit

Permalink
fixup! REDSHIFT: standardize credential usage
Browse files Browse the repository at this point in the history
  • Loading branch information
Zachary Salzbank committed Mar 22, 2017
1 parent 2f2ef70 commit 073a1e3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions luigi/contrib/redshift.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,14 @@ def _get_s3_configuration_attribute(self, attribute):
except NoSectionError:
value = None

if value is None or value == '':
if not value:
value = os.environ.get(attribute.upper(), None)

return value

def _credentials(self):
"""
Return a credentials string for the provided task. If no valid
Return a credential string for the provided task. If no valid
credentials are set, raise a NotImplementedError.
"""

Expand Down

0 comments on commit 073a1e3

Please sign in to comment.