[WIP] Salesforce does not download all results for large result set #1685
Comments
|
@dacort Sorry about this. I wrote the bulk of Salesforce.py. Most of my salesforce queries involve the salesforce version of joins and so I was never able to use/test batch results well. Thanks for your desire to improve this module! |
|
No problem @dlstadther! Happy to be able to contribute. :) |
1 task
dacort
changed the title
|
Just realized this creates a CSV file with multiple headers. This shouldn't be merged in yet. |
|
Once things are fixed, i'll review once more |
Tarrasch
pushed a commit
that referenced
this issue
May 19, 2016
* #1685 Add support for multiple results in batch jobs Adds a new method 'get_batch_result_ids' and maintains backwards compatibility with the old method, adding a warning. * Add the ability to merge result sets and basic testing. Note that this only supports CSV since this is what the library does by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For particularly large result sets, Salesforce will return multiple result IDs for a single batch.
However, in
get_batch_results, only the first result ID is being returned. The code should utilizeET.findallto return a list of result IDs and download each of those to append to the output file.I'm planning on submitting a PR for this in the next couple of days.
The text was updated successfully, but these errors were encountered: