Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using default_scheduler_url as a mounting point (not root http://address/mount) behind proxy not working #3213

Closed
franckOL opened this issue Dec 13, 2022 · 1 comment · Fixed by #3216

Comments

@franckOL
Copy link
Contributor

I need to mount luigi behind a nginx, for example luigi at http://address/mount.
For that I configure:

[core]
default_scheduler_url=http://address/mount
....

GUI is ok and works but, CLI not due to url resolution. it happens there

def _urljoin(base, url):

To understand what happened:

parsed=urlparse('http://address/mount')
url='/api/add_task'
urljoin(parsed.geturl(), url)
# ==> give 'http://address/api/add_task'
# expected http://address/mount/api/add_task

What I must do for working - slash at the end of mount point, no slash for url -:

parsed=urlparse('http://address/mount/')
url='api/add_task'
urljoin(parsed.geturl(), url)
# ==> http://address/mount/api/add_task
@honnix
Copy link
Member

honnix commented Jan 16, 2023

I think having the slash is expected.

dlstadther added a commit that referenced this issue Feb 23, 2023
#3216)

* fix: using default_scheduler_url as a mounting point for not root path. fix #3213

Signed-off-by: ROUDET Franck INNOV/IT-S <[email protected]>

* Add test for not root default_scheduler_url

Signed-off-by: ROUDET Franck INNOV/IT-S <[email protected]>

* Test passed

Signed-off-by: Franck Roudet <[email protected]>

---------

Signed-off-by: ROUDET Franck INNOV/IT-S <[email protected]>
Signed-off-by: ROUDET Franck INNOV/IT-S <[email protected]>
Signed-off-by: Franck Roudet <[email protected]>
Co-authored-by: ROUDET Franck INNOV/IT-S <[email protected]>
Co-authored-by: Dillon Stadther <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants