Add explicit whitelist of RPC commands for luigid #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! |
| 'graph', | ||
| 'inverse_dep_graph', | ||
| 'ping', | ||
| 'prune', |
There was a problem hiding this comment.
Not sure if this actually should be public. But whatever.
There was a problem hiding this comment.
To clarify. I'm not sure it makes sense for clients to be able to call prune. Many other of the API calls does call prune internally themselves, like graph, inverse_dep_graph etc.
This was just a minor comment so I just merged right away.
|
Nice! Thanks :) |
Tarrasch
added a commit
that referenced
this pull request
Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit calls on Scheduler from API to only those required for functionality.
Basic functionality testing was conducted, but not extensive testing.